Automate JS asset compilation and update package manifest#158
Open
irtazaakram wants to merge 2 commits intomainfrom
Open
Automate JS asset compilation and update package manifest#158irtazaakram wants to merge 2 commits intomainfrom
irtazaakram wants to merge 2 commits intomainfrom
Conversation
salman2013
requested changes
Feb 13, 2026
salman2013
approved these changes
Feb 13, 2026
Contributor
salman2013
left a comment
salman2013
left a comment
There was a problem hiding this comment.
LGTM, I discussed the testing details with @irtazaakram, and based on the results, I’m comfortable proceeding with the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1-
setup.pynow runsnpm installandnpm run buildautomatically during installation.2- The build process checks for
npmandpackage.jsonfirst, skipping gracefully if they are missing (safe for production/PyPI).3- Updated
MANIFEST.in toexplicitly include runtime assets (HTML, YAML, compiled JS/CSS) and exclude development clutter (node_modules, tests).4- Updated
.gitignoreand GitHub Actions to align with the new build process.